-
Notifications
You must be signed in to change notification settings - Fork 644
[UX][k8s] show-gpus for all allowed contexts #5362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Re: UI, I do agree on having a table showing aggregated GPU availability across all clusters. I actually think such table should be at the top, because the current UI places per-context GPU availability above node level availability, so it already has a flow of information going from more general -> more specific from top to bottom. |
implemented! |
Co-authored-by: Seung Jin <seungjin219@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @kyuds!
Minor to above: would be good to replace None with |
I actually think that if a node doesn't contain any GPU then it shouldn't show up on the table |
This PR also seems causing a backward compatibility issue due to the return value of the request from API server changes.
|
Another UX feedback: It seems currently we show:
For SkyPilot users, GPUs are much more important than node information. A better way to show this is to show:
|
Fixes #5313
IMPORTANT! Feedback PleaseI didn't know whether it would be desirable, but I think it would be a good idea to show a final table that would merge all available accelerators across all k8s clusters? The user might want to only know the total availability across clusters. I think that might be a helpful summary feature. For instance, for the above image, we would have:
EDIT (25.04.27): implemented above feature as suggested in below comment
Some Behavioral Changes:
Tested (run the relevant ones):
bash format.sh
/smoke-test
(CI) orpytest tests/test_smoke.py
(local)/smoke-test -k test_name
(CI) orpytest tests/test_smoke.py::test_name
(local)/quicktest-core
(CI) orpytest tests/smoke_tests/test_backward_compat.py
(local)